Embed kind for bound variables #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See TODO comment in changes. This requires further changes such that we can more accurately describe the kind of a bound type variable found in an instance declaration's constraints. For now, using a unification variable should suffice and allows the tests to be solved.
This makes us less reliant on the implicit scope when transferring types across the global/local contexts. This also removes the workaround in constraint.rs that uses unification variables to stand in for the erased kind information important for correctness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the representation of Variable::Bound to carry its kind similar to Variable::Skolem. Tests have been updated to verbosely pretty-print the kinds of both bound and skolem type variables.